Fix last character of JSX text nodes being cut off #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the last character of JSX text nodes was being truncated during the compilation process. The issue was in the fixupWhitespaceAndDecodeEntities function which was using an incorrect slice range when extracting text content from JSX nodes.
- Fixes character truncation in JSX text nodes by correcting slice bounds
- Updates test baselines to reflect the corrected text extraction behavior
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/transformers/jsxtransforms/jsx.go | Fixes the slice range bug by changing lastNonWhitespace to lastNonWhitespace+1 and corrects a typo |
| testdata/baselines/reference/submodule/* | Updates test baseline files to reflect the corrected JSX text output |
|
@microsoft-github-policy-service agree |
gabritto
approved these changes
Sep 9, 2025
jakebailey
approved these changes
Sep 9, 2025
| // (lastNonWhitespace === -1 is a special flag to detect whether the first line is all whitespace.) | ||
| if firstNonWhitespace != -1 && lastNonWhitespace != -1 { | ||
| addLineOfJsxText(acc, text[firstNonWhitespace:lastNonWhitespace], initial) | ||
| addLineOfJsxText(acc, text[firstNonWhitespace:lastNonWhitespace+1], initial) |
There was a problem hiding this comment.
Yep, original code was:
acc = addLineOfJsxText(acc, text.substr(firstNonWhitespace, lastNonWhitespace - firstNonWhitespace + 1));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal repro, in test case format:
Behavior with
[email protected]Behavior with
tsgo"Foo" is truncated to "Fo":